Adding support for azure service bus as input with Azure Default Credentials support #481
Conversation
…t Credentials support
…t Credentials support
…t Credentials support
|
@jem-davies @gregfurman could I ask you for review this changes? I want to ask if it will be possible to release 1.11.1 with this changes ? |
Thanks for the contribution 😎 - I would suggest considering implementing a plugin, while this PR is in review. We don't typically add components in a patch release, and there are a few other PRs to review as well... |
|
Hey! @adrianhaj 👋 Thanks for the super neat contribution 🤩 I'm busy reviewing this PR, and should be done by a bit later today. |
There was a problem hiding this comment.
Thank you for the fantastic PR! Really appreciate your usage of shutdown signallers to ensure this component cleans up gracefully 🤩
Genuinely a lot of fun to review, so kudos on the contribution 😄 Have left some comments and suggestions. Nothing really blocking but would like to hear your feedback on some of what I've raised.
| a.locksMutex.Unlock() | ||
| } | ||
|
|
||
| func (a *azureServiceBusQueueReader) stopAllLockRenewals() { |
There was a problem hiding this comment.
non-blocking: I'm going to do a follow-up comment on this, but. think we can re-work this lock tracking using a singleflight.Group. Perhaps I'll open a seperate PR targeting this branch on your forked repo and we can see whether you think it works.
There was a problem hiding this comment.
I will be grateful if you can 🙏
Co-authored-by: Greg Furman <[email protected]>
Thank you for review :) I will try to apply all changes as soon as possible :) |
Co-authored-by: Greg Furman <[email protected]>
Co-authored-by: Greg Furman <[email protected]>
…vice Bus queue input
|
…Bus queue input shutdown
3 participants
No description provided.